search

jwood000 / RcppAlgos

Tool for Solving Problems in Combinatorics and Computational Mathematics
GNU General Public License v2.0
45 stars 5 forks source link

Features/code quality #31

Closed jwood000 closed 2 years ago

jwood000 commented 2 years ago

Replaced all occurrences of:

SEXP var = PROTECT(...);
some code
UNPROTECT(1);
return res;`

with:

cpp11::sexp var = ...
some code
return res;
codecov[bot] commented 2 years ago

Codecov Report

Merging #31 (b688dc1) into main (23d3f8d) will decrease coverage by 0.13%. The diff coverage is 86.80%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   96.04%   95.91%   -0.14%     
==========================================
  Files         126      126              
  Lines       11361    11259     -102     
==========================================
- Hits        10912    10799     -113     
- Misses        449      460      +11
Impacted Files Coverage Δ
src/CleanConvert.cpp 76.37% <51.68%> (-9.65%) :arrow_down:
src/CartesianContainer.cpp 84.29% <84.14%> (+2.33%) :arrow_up:
src/GetPrevCombPermApply.cpp 95.91% <89.58%> (-1.40%) :arrow_down:
src/SampleApply.cpp 95.11% <93.58%> (-1.21%) :arrow_down:
R/ComboGrid.R 95.00% <100.00%> (+0.40%) :arrow_up:
src/CheckReturn.cpp 92.30% <100.00%> (-0.20%) :arrow_down:
src/ClassUtils.cpp 95.89% <100.00%> (-0.17%) :arrow_down:
src/CnstrntsSpecialClass.cpp 100.00% <100.00%> (ø)
src/CnstrntsToRClass.cpp 98.81% <100.00%> (-0.03%) :arrow_down:
src/ComboApplyClass.cpp 96.20% <100.00%> (-0.06%) :arrow_down:
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23d3f8d...b688dc1. Read the comment docs.