Closed Clauvin closed 5 years ago
Thanks for logging these, I'll see if I can get to the bottom of them.
The game in fact already saves the card pool and the rest of the game state after every room—this code is triggering off of that save. That code can probably be optimized to only include Hayseed cards, though.
Can you tell me how large your card pool actually was at the time of the trace?
The game in fact already saves the card pool and the rest of the game state after every room—this code is triggering off of that save. That code can probably be optimized to only include Hayseed cards, though.
Hm... then maybe the problem is less the extra save and more all the extra lines printed thanks to that save? Prints tend to slow down programs a bit, and with so many called...
Can you tell me how large your card pool actually was at the time of the trace?
Of course, 1430 cards.
Ok, that's good—I wanted to make sure my save code wasn't double-counting cards (which is something that happened before).
I had the same thought about logging and I think you may be right. Fortunately removing that is an easy fix. I'll make that change and push it up soon.
My counting was based in the log number at the end of the save, let me check if there's any double-counting.
It's not double-counting!
This should (hopefully) be resolved with https://github.com/jwoolley/simpleton-mod/commit/732059c39869e8a25c734bdf4a789fc3795b93ae.
Fixed with the referenced commit.
What happened: The game stopped for more or less 15 seconds each time I entered or left any room.
What exactly happened: Played a Custom Game, using modifiers to have a card pool of 10+ characters (3 base game + Tenno, Marisa, The Florist, Hayseed and others). Was using The Florist and every time I would enter in a room...
Why this was a problem: If it happened once, fine, but it was happening twice for each room, so in an act of 15 rooms traveled, with more or less 30 seconds per room with the game paused...
...this meant a total of 7 minutes and 30 seconds waiting for each 15 rooms. :/
The character really needs to save the whole card pool? And every time a room is entered/left behind?