Closed Janiczek closed 2 years ago
Thank you for the detailed report, as usual! I think there's probably some race condition at play here. I plan to give this a look tomorrow!
I introduced this bug in the fix for the undo logic introduced in https://github.com/jwoudenberg/elm-pair/issues/10. The undo detection logic would report false positives in the middle of a rename, causing Elm-pair to loose the thread. I made a fix that approaches undo's in a simpler way. Undo still seems to work, and Elm-pair doesn't hang up anymore, at least not when I'm ramming onto my keyboard as quickly as I can :).
The fix is out as release 10, let me know how it works for you! And thank you again for bringing the issue!
Seems to work much better! Thank you @jwoudenberg :heart:
Sometimes the renaming refactor stops in the middle in diffs like:
followed by
resulting in
(note the
cSorting
in expr compared to thecoSorting
in the fn argument)while if I write slowly letter by letter (
` ->
c->
coetc., instead of
->
co`), it's all fine. Seems like big changes all at once confuse elm-pair?https://user-images.githubusercontent.com/149425/152877481-5dcfde4f-90bf-41d1-8af3-33a905aceec5.mp4