jwouellette / TPF-5_372-Unit_Test_Suite

Test instruction and IFC file repository for the BIM for Bridges and Structures Transportation Pooled Fund project
7 stars 0 forks source link

UTS Spatial Breakdown Structure does not validate in updated bSI Validation Service #14

Closed RickBrice closed 4 months ago

RickBrice commented 4 months ago

I've been building models using the UTS spatial breakdown structure. When run through the updated bSI Validation Service, there are multiple errors regarding the spatial breakdown.

For example, the UTS has IfcBridgePart.SUPERSTRUCTURE and IfcBridgePart.SUBSTRUCTURE are aggregated to the IfcBridge. The validation service says they should be part of IfcSpace. The documentation for IfcSpace seems to support this https://standards.buildingsmart.org/IFC/RELEASE/IFC4_3/HTML/lexical/IfcSpace.htm

I'm getting validation errors throughout the entire spatial breakdown based on the UTS.

Is anyone experiencing the same?

SergejMuhic commented 4 months ago

Validation services certainly has some false evaluations there. The documentation says that IfcSpace can only be decomposed into another IfcSpace.

image

RickBrice commented 4 months ago

Here is an example for a 1-span bridge. It seems like the validation service doesn't like anything to Superstructure, Substructure, Abutments, Foundation.

I'm entirely open to the possibility that I've got it wrong.

PGSuper1.ifc.txt

image

SergejMuhic commented 4 months ago

Alright, so the problem are IfcBridgePart decomposed by IfcBridgePart. That csv table from your screenshot does not allow it (for whatever reason).

The definition for IfcBridgePart below was submitted to bSI by the IFC Bridge project but apparently they chose to ignore it.

image

TLiebich commented 4 months ago

but this should be an error in the validation service, bridge parts (and any facility part) should be able to be decomposed into other bridge parts (same applies to the even stricter building spatial hierarchy, where a building can be decomposed into other buildings (e.g. acting as building sections). @RickBrice best you file it as an error to the validation service team.

evandroAlfieri commented 4 months ago

Thanks for finding it. We copied the general usages from the spatial decomposition template...which obviously requires fixing too. I'm on it (both docs and vs rule)

RickBrice commented 4 months ago

Fixed - see https://github.com/buildingSMART/validate/issues/61