Bug: Node Modules directory committed to repo

jwpf100 / node-blog

Blogging App - CRUD backend for Admin to add, amend and delete articles. API to pass data on to Frontend. Express used for routing. MongoDB for storage. Hosted on AWS using NginX reverse proxy.

0 stars 0 forks source link

Bug: Node Modules directory committed to repo #9

Closed Moppler closed 3 years ago

Moppler commented 3 years ago

Problem

node_modules directory is committed to repository. There are two issues with this:

Having so many tracked files makes pulling the repository take a lot longer than it needs to (This is especially a problem if you ever get into automated deployment where you pay for server time).
The directory has been added to the .gitignore file so further changes aren't being tracked anyway.

Acceptance Criteria

node_modules directory is removed from version control.

jwpf100 commented 3 years ago

@MattGibney Hey Matt, I couldn't add you as a reviewer to the pull request above, but I think this should make it visible to you.

Moppler commented 3 years ago

You couldn't add me as a reviewer because the PR was marked as a draft. I updated it to remove the draft status and added myself as a reviewer.