Added EventBus and modularized Playback and TVOSAnalytics

jwplayer / jw-showcase-appletv

An Apple TV app builder written in TVJS with support for videos streamed out of the JW Player platform

Other

87 stars 44 forks source link

Added EventBus and modularized Playback and TVOSAnalytics #28

Closed RikHeijdens closed 8 years ago

RikHeijdens commented 8 years ago

This PR contains the following changes:

Added a global EventBus that can be used to broadcast Events.
Playback.js has been refactored into a module.
TVOSAnalytics.js has been refactored into a module that subscribes to events broadcasted by Playback.js
ConfigLoader now allows you to dynamically load extra modules that have been specified in the CONFIG file.

This branch still needs a little work, but the PR has been opened so @pablos1 can start reviewing.

pablos1 commented 8 years ago

Ok, this looks like it's in good shape. @RikHeijdens you'll need to rebase onto master and fix some conflicts, but other than that it should be good to go.

RikHeijdens commented 8 years ago

@pablos1 Cool, I'll close this PR and push a new rebased branch.

pablos1 commented 8 years ago

No need to close the PR; you can rebase, resolve the conflicts and commit back to the same branch.

On Monday, February 29, 2016, Rik Heijdens notifications@github.com wrote:

@pablos1 https://github.com/pablos1 Cool, I'll close this PR and push a new rebased branch.

— Reply to this email directly or view it on GitHub https://github.com/jwplayer/appletv/pull/28#issuecomment-190102551.

Pablo Schklowsky, SVP, Video Platform _JW_PLAYER | Your Way to Play pablo@jwplayer.com | jwplayer.com

Follow us on: facebook https://www.facebook.com/jwplayer, twitter http://twitter.com/jwplayer, linkedin http://www.linkedin.com/company/1907786