issues
search
jwplayer
/
jwplayer-react-native
MIT License
32
stars
9
forks
source link
Fix all tracks are being marked captions
#19
Closed
Jmilham21
closed
6 months ago
Jmilham21
commented
6 months ago
What does this Pull Request do?
Start parsing for different tracks types from the
tracks
prop
Why is this Pull Request needed?
When using legacy props, there was no way to load in anything other than caption tracks
Are there any points in the code the reviewer needs to double check?
No, but since iOS doesn't require
kind
, we cannot make it required. This causes the need for the check if
kind
key exists.
Are there any Pull Requests open in other repos which need to be merged with this?
no
Addresses Issue(s):
GitHub Issue
What does this Pull Request do?
tracks
propWhy is this Pull Request needed?
Are there any points in the code the reviewer needs to double check?
kind
, we cannot make it required. This causes the need for the check ifkind
key exists.Are there any Pull Requests open in other repos which need to be merged with this?
Addresses Issue(s):
GitHub Issue