search

jwplayer / jwplayer-react-native

MIT License
32 stars 9 forks source link

feat: shrink bundle by replacing lodash with lodash.isequalwith #42

Closed chriszs closed 5 months ago

chriszs commented 5 months ago

What does this Pull Request do?

Reduces the bundle size of the package by replacing lodash with lodash.isequalwith.

Why is this Pull Request needed?

Lodash is among the largest dependencies in one representative app, this decreases the JavaScript bundle size by half a megabyte.

Are there any points in the code the reviewer needs to double check?

This should in theory work identically, but may be worth checking that the shouldComponentUpdate check functions the same.

Are there any Pull Requests open in other repos which need to be merged with this?

No.

Addresses Issue(s):

GitHub Issue