search

jwplayer / jwplayer-react-native

MIT License
32 stars 9 forks source link

Fix unable to run on iOS simulator with ads turned on #50 #51

Closed dominictobias closed 4 months ago

dominictobias commented 5 months ago

Fixes the ability to run on an iOS Simulator with ads turned on #50

Could pin the version but this bug occurred because you didn't allow patch versions - up to you

Screenshot 2024-06-13 at 5 14 45 PM

P.S. Do I need to explicitly do something else to enable ads, like fill out advertising?: JwAdvertisingConfig in JwConfig? The docs don't mention anything

david-almaguer commented 5 months ago

@dominictobias It's okay to support patch versions since the public API of the GoogleIMA SDK wouldn't be affected. Thanks for addressing this. Regarding enabling GoogleIMA Ads, you need to set the global constant RNJWPlayerUseGoogleIMA, after doing that you need to set your ads configuration via JwAdvertisingConfig, refer to this link for specific parameters per platform.