search

jwplayer / jwplayer-react-native

MIT License
32 stars 9 forks source link

fix: prevent iOS crash when Google Cast is not enabled and React Native's new architecture is #61

Closed chriszs closed 4 months ago

chriszs commented 4 months ago

What does this Pull Request do?

Removes the cast methods from the list of methods exported to React Native on iOS when USE_GOOGLE_CAST is not enabled.

Why is this Pull Request needed?

iOS apps without this crash on React Native's new architecture after being built with Google Cast support, because otherwise the code tries to reference missing methods.

Are there any points in the code the reviewer needs to double check?

No.

Are there any Pull Requests open in other repos which need to be merged with this?

No.

Addresses Issue(s):

GitHub Issue

Jmilham21 commented 4 months ago

Thanks, @chriszs. This resolves the build issue for iOS. We have some internal tickets to ensure we best support the new architecture, but this should get everyone started on iOS, at least.

I think something with the new architecture is breaking our Android implementation. We will address this with our internal ticket unless you or someone wants to tackle it first