Implement PiP receiver. Refactor Example to better implement PiP. Fix view display issue in PiP - Githubissues

jwplayer / jwplayer-react-native

MIT License

32 stars 9 forks source link

Implement PiP receiver. Refactor Example to better implement PiP. Fix view display issue in PiP #66

Closed Jmilham21 closed 3 months ago

Jmilham21 commented 3 months ago

What does this Pull Request do?

Enhance PiP implementation
Fix Toolbar displaying in PiP issue in Example
Slightly resolve the PiP issue where player isn't centered

Why is this Pull Request needed?

PiP on Android isn't working well
Example app wasn't setup well for PiP

Are there any points in the code the reviewer needs to double check?

Test implementation with the following config

let jwConfig = {
"title": "Single Inline Linear Preroll",
"playlist": [
  {
    "title": "Single Inline Linear Preroll",
    "file": "https://content.bitsontherun.com/videos/q1fx20VZ-52qL9xLP.mp4"
  }
],
"pipEnabled":true
}

Hiccup when switching into PiP... React Native seems to want to reshow the toolbar so I had to take some workaround steps to ensure the Player is rendered in frame of PiP.

Are there any Pull Requests open in other repos which need to be merged with this?

No

Addresses Issue(s):

Internal JWP ticket