search

jwplayer / jwplayer-react-native

MIT License
32 stars 9 forks source link

[BUG] Previous video gets played on the Chromecast device #87

Open Jmilham21 opened 1 month ago

Jmilham21 commented 1 month ago

What does this Pull Request do?

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Are there any Pull Requests open in other repos which need to be merged with this?

Addresses Issue(s):

GitHub Issue

guillermomachado commented 1 month ago

@Jmilham21 I've integrated these changes as a patch package into my project, and it fixed the issue mentioned in the PR, along with some problems when changing the video while it was playing. However, I've noticed an issue when the video completes: after it finishes, it seems like the connection isn't handled properly, and we can't cast a new video. Is this a problem for you? Could you advise?

Thank you!

Jmilham21 commented 1 month ago

Hey @guillermomachado, I'm glad it's somewhat better, but could you give me the steps to reproduce what you're experiencing? I have a hunch, but I don't want to chase a bug wildly.

guillermomachado commented 1 month ago

@Jmilham21 Thanks for your quick response. The steps:

1) Cast a video to a Chromecast. 2) Wait for it to finish. 3) Try to cast a new video.

See how the Chromecast shows the app's name and doesn't play a new video.

Jmilham21 commented 1 month ago

@Jmilham21 Thanks for your quick response. The steps:

  1. Cast a video to a Chromecast.
  2. Wait for it to finish.
  3. Try to cast a new video.

See how the Chromecast shows the app's name and doesn't play a new video.

I have tested and confirmed 😞. I will work on a further patch and update this branch and you when I have more @guillermomachado