search

jwplayer / jwplayer-react

ISC License
28 stars 13 forks source link

Add TypeScript typings #29

Open amowu opened 5 months ago

amowu commented 5 months ago

This PR will...

Add @jwplayer/jwplayer-react TypeScript types

Why is this Pull Request needed?

Cannot find module '@jwplayer/jwplayer-react' or its corresponding type declarations.

CleanShot 2024-03-25 at 16 10 20@2x

Are there any points in the code the reviewer needs to double check?

After npm publish, you can use tools like CodeSandbox to create a React TypeScript project to check whether import JWPlayer from '@jwplayer/jwplayer-react' will still display this error message.

Are there any Pull Requests open in other repos which need to be merged with this?

N/A

Addresses Issue(s):

4

jwplayer-robot commented 5 months ago

Can one of the admins verify this patch?

bosworthco commented 3 months ago

Minor update needed to type DidMountCallback = (DidMountCallbackArguments) => void;

See #28