jwplayer / jwplayer-react

ISC License
28 stars 13 forks source link

[JW8-12349] Add ability to modify on event props #5

Closed mamaddox closed 2 years ago

mamaddox commented 2 years ago

This PR will...

JW8-12349

mamaddox commented 2 years ago

test this please

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit cac54bee1d72bc38b81d08c2636348d611dfc5cc passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 30630 SUCCESS :eggplant: Squash PR build 30630

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit 156839ba41135c2cb563a055560bb264e30a4068 passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 30658 SUCCESS :eggplant: Squash PR build 30658

m4olivei commented 2 years ago

Would this also solve the issue stated in https://github.com/jwplayer/jwplayer-react/issues/3 ?

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit 4c17015db22ccdbef16c2e3ef9ea7f2d87d56384 passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 30986 SUCCESS :eggplant: Squash PR build 30986

mamaddox commented 2 years ago

@m4olivei Hey Matthew! Based on my reading of the issue, it looks like this should fix that. This will make it so that if any on events change, the event listeners will be updated for the player. May just need to do a retest when this gets merged in.

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit 74a3a59de8e5b9cf92b2e0ea17897ea0d68c794f passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 31011 SUCCESS :eggplant: Squash PR build 31011

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit 1532a3b371879677a061028e918b5a11d7662eed passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 31012 SUCCESS :eggplant: Squash PR build 31012

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit b91fbaca75ba1548c447e06b8fb7dd8182d57879 passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 31081 SUCCESS :eggplant: Squash PR build 31081

jwplayer-robot commented 2 years ago

:white_check_mark: Build for commit 6ef284af1fda3d3828c7735a860e34afd9e14172 passed. :clipboard: react unit-tests SUCCESS :building_construction: jwplayer-commercial build 31101 SUCCESS :eggplant: Squash PR build 31101