jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Fix / notifications handler #385

Closed kiremitrov123 closed 11 months ago

kiremitrov123 commented 11 months ago

Description

This PR -Improves overall the payment flow because the refresh page is eliminated after notification is received. -Improves the notifications handling -Fixes bugs about message handling with TVOD items Jira cards: -Improve TVOD flow for web app -TVOD offer bugs (JW)

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 11 months ago

Visit the preview URL for this PR (updated for commit de99573):

https://ottwebapp--pr385-fix-notifications-ha-6nza5y7j.web.app

(expires Sat, 04 Nov 2023 15:40:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

darkoatanasovski commented 11 months ago

@dbudzins @ChristiaanScheermeijer @AntonLantukh @kiremitrov123 Do we need to refactor the notifications feature in this PR, or should we focus on fixing the bug and improving the redirect after receiving the notification? If we want to enhance the feature, let's plan it next week. However, if we only need to address the bug in this PR, let's proceed with the merge because we don't have time today to refactor the entire feature. What do you think?