jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Refactor `useService` hook from being a hook #386

Closed ChristiaanScheermeijer closed 7 months ago

ChristiaanScheermeijer commented 11 months ago

This will be solved by the services/Inversify refactor, but I wanted to note that currently, the useService hook is not actually a hook. It works now because it is not using other hooks, but useService is mostly used in controller methods that are called from useQuery and useMutation functions.

This can lead to problems when doing performance updates or using other hooks later.

ChristiaanScheermeijer commented 7 months ago

Not relevant anymore since #363