search

jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

refactor(project): separate integration from services #396

Closed ChristiaanScheermeijer closed 9 months ago

ChristiaanScheermeijer commented 10 months ago

@AntonLantukh @dbudzins I was trying some things out after discussing #363. I will leave it here as input or for inspiration 😄.

Things I like:

  1. Root.tsx is becoming more and more simple (we can go further)
  2. Integrations can be added without adding or changing multiple parts of the application
  3. We can eliminate all the integration-specific code (access model calculation, etc.)
  4. container.ts is placed in the src folder

Things I'm not sure about:

  1. A new custom hook is introduced, useBootstrapApp
  2. AppController might be renamed to ConfigController because it doesn't orchestrate the app bootstrap anymore (intended)
  3. ...?
github-actions[bot] commented 10 months ago

Visit the preview URL for this PR (updated for commit 527886c):

https://ottwebapp--pr396-feature-services-mod-dktulwv8.web.app

(expires Wed, 13 Dec 2023 23:40:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529