Unable to scroll landingpage / shelves - Githubissues

jwplayer / ott-web-app

Reference implementation for JWP-powered apps

Apache License 2.0

69 stars 53 forks source link

Unable to scroll landingpage / shelves #438

Open marcovandeveen opened 6 months ago

marcovandeveen commented 6 months ago

For some viewers, when you use the right or left controls of theTileSlider component, it doesn't scroll.

It's not happening on all devices. But we have a couple of machines showing the behavior.

So far, it looks like it is NOT related to:

OS: happens on windows, mac, ios
Browser: happens on chrome, safari, firefox
Screensize: same device, different screens, same issue
Timing related: it happens consistently on a particular device

It seems to be introduced as in v4.26.0 , when the web app got upgraded to React 18.

https://github.com/jwplayer/ott-web-app/assets/42120041/e99e1010-dc89-4e61-9b85-8b5e506d0b17

https://github.com/jwplayer/ott-web-app/assets/42120041/f5aec2d4-6af5-426e-8b91-086fdb9bd300

https://github.com/jwplayer/ott-web-app/assets/42120041/0355e070-da19-408d-a2f9-d7f3ac75498f

https://github.com/jwplayer/ott-web-app/assets/42120041/76e781cd-9644-43b1-8c48-ac11948571a1

marcovandeveen commented 6 months ago

Update: The behavior can be traced back to whether the slider is animated.

This is based on some 'browser magic' here: https://github.com/jwplayer/ott-web-app/blob/develop/src/components/TileDock/TileDock.tsx#L69
Some browsers give this as a setting, but others don't, and derive it from OS settings

The preview link in https://github.com/jwplayer/ott-web-app/pull/437/files fixes it.

ChristiaanScheermeijer commented 6 months ago

This issue is fixed by #437, right?

dbudzins commented 5 months ago

@ChristiaanScheermeijer yes and no... that fix fixes the majority of issues, but we still have a repro on ipad that's still broken with the new code.