search

jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
69 stars 53 forks source link

Fix / Prevent double id attribute #441

Closed langemike closed 6 months ago

langemike commented 6 months ago

Two e2e tests failed because all the read-only<input>s on the page had the same ID. Causing Playwright to fail.

Happened because of this call:

cardInfo.forEach(([label, value]) => I.seeInField(label, value));

Applying a name fixed this, but I also marked the name property required, to prevent this issue from happening in the future. Double IDs can also lead to issues with clicking on a <label> which is linked to the wrong <input>.

Caused by: PR #38

langemike commented 6 months ago

Mistake