jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
69 stars 53 forks source link

fix: update favorites and watch history lists when empty result #447

Closed mirovladimitrovski closed 4 months ago

mirovladimitrovski commented 5 months ago

Description

This PR solves #PS-77. https://jwplayer.atlassian.net/browse/PS-77

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 1af6fed):

https://ottwebapp--pr447-ps-77-profiles-cachi-eh4hng9l.web.app

(expires Wed, 06 Mar 2024 10:06:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

ChristiaanScheermeijer commented 5 months ago

I actually made the same changes yesterday in an upcoming refactor branch. It should be fine, though...

https://github.com/Videodock/ott-web-app/pull/37/files#diff-a08daab854bf0e61214fcae0e2ee7c11fddaa17b57fe8e714fae3fbe5fc3e4c5L48

https://github.com/Videodock/ott-web-app/pull/37/files#diff-7a5a56b9f122b14fcd7fd0c1ed20693bcedb9f2c060dbe56c6403d6bc12f2c67L58

mirovladimitrovski commented 5 months ago

I actually made the same changes yesterday in an upcoming refactor branch. It should be fine, though...

https://github.com/Videodock/ott-web-app/pull/37/files#diff-a08daab854bf0e61214fcae0e2ee7c11fddaa17b57fe8e714fae3fbe5fc3e4c5L48

https://github.com/Videodock/ott-web-app/pull/37/files#diff-7a5a56b9f122b14fcd7fd0c1ed20693bcedb9f2c060dbe56c6403d6bc12f2c67L58

That's quite a big refactor. I think it'd be better to merge this fix first, so we can have it sooner.

ChristiaanScheermeijer commented 4 months ago

@dbudzins @mirovladimitrovski this PR is redundant because #450 was merged which already had this fix 😄