Feat/small features and refactoring - Githubissues

jwplayer / ott-web-app

Reference implementation for JWP-powered apps

Apache License 2.0

69 stars 53 forks source link

Feat/small features and refactoring #450

Closed ChristiaanScheermeijer closed 5 months ago

ChristiaanScheermeijer commented 5 months ago

Description

Features

Dynamic GTM tag injection via an environment variable
Custom footer text using markdown via an environment variable
Initiative for replaceable components
Automatic favicon/PWA image generator using a single base icon
Dynamic PWA manifest generation

Refactoring

Make routing paths static
Typing refactoring (.d.ts -> .ts), which revealed some typing problems
Update the reload subscriptions mechanism
Move controllers to its own directory
Move logic from containers/hooks to controllers (progress has been made, but more is planned)

Fixes

Prevent a crash when history or favorites fails to load (duplicate IDs)
Inline player not supporting TVOD (will always show the paywall)
TVOD subscriptions not reloaded on non-SVOD platforms
Customer IP not defined when creating a Cleeng order
Error when deleting an InPlayer account
Unexpected errors (crashes) not showing the ErrorPage
Start watching button shown for TVOD items in AVOD platform (no integration configured)

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 2741eac):

https://ottwebapp--pr450-feat-small-features-jtc1jkeb.web.app

_{(expires Thu, 21 Mar 2024 13:09:37 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: c198f8a3a199ba8747819f7f1e45cf602b777529}

ChristiaanScheermeijer commented 5 months ago

Thanks for reviewing this thoroughly @dbudzins, I've implemented most of the requested changes. Let me know what you think!

Have a good weekend 😄

AntonLantukh commented 5 months ago

@ChristiaanScheermeijer thank you! I still have some questions regarding continue watching / favorites logic. I will take one more look tomorrow.

AntonLantukh commented 5 months ago

@ChristiaanScheermeijer thank you for the changes!

ChristiaanScheermeijer commented 5 months ago

Thanks for reviewing @dbudzins and @AntonLantukh 👍 🙌

ChristiaanScheermeijer commented 5 months ago

@dbudzins @AntonLantukh, can we merge this when you're ready? (the next PRs are already on the way 😄)