jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

chore: replace depcheck with knip #462

Closed dbudzins closed 6 months ago

dbudzins commented 6 months ago

Description

Depcheck was getting annoying with monorepo tools and refactoring. It doesn't work with any local imports besides relative paths, so tsconfig baseurl and paths all have to be manually added to the depcheck ignore file. See https://github.com/depcheck/depcheck/issues/564.

Knip does the same thing, but does take tsconfig and other environments into consideration. Additionally, knip uses a single, combined config file, which seems easier to manage than all of the fragmented depcheck files.

Steps completed:

According to our definition of done, I have completed the following steps:

~- [ ] Acceptance criteria met~ ~- [ ] Unit tests added~ ~- [ ] Docs updated (including config and env variables)~ ~- [ ] Translations added~ ~- [ ] UX tested~ ~- [ ] Browsers / platforms tested~

github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit 5701067):

https://ottwebapp--pr462-dbudzins-replace-dep-0hg4c6mr.web.app

(expires Wed, 17 Apr 2024 16:15:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529