jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Feat / modal manager #485

Closed ChristiaanScheermeijer closed 4 months ago

ChristiaanScheermeijer commented 6 months ago

Description

This PR implements a ModalProvider and useModal hook that manages the visible modals when registered via the useModals hook.

By doing so, the following features are added:

This change removes lots of duplicate code from the Modal and Sidebar components.

See the whole discussion and review here: https://github.com/Videodock/ott-web-app/pull/167

github-actions[bot] commented 6 months ago

Visit the preview URL for this PR (updated for commit a8d4d80):

https://ottwebapp--pr485-feat-modal-manager-24vtofrp.web.app

(expires Fri, 10 May 2024 10:18:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

ChristiaanScheermeijer commented 5 months ago

Superseded by #505

AntonLantukh commented 4 months ago

@ChristiaanScheermeijer I will close this one.