fix: only remove token from hash after login with social media

jwplayer / ott-web-app

Reference implementation for JWP-powered apps

Apache License 2.0

70 stars 52 forks source link

fix: only remove token from hash after login with social media #499

Closed mirovladimitrovski closed 5 months ago

mirovladimitrovski commented 5 months ago

Description

This PR solves OWA-74.

Steps completed:

According to our definition of done, I have completed the following steps:

[x] Acceptance criteria met
[ ] Unit tests added
[ ] Docs updated (including config and env variables)
[ ] Translations added
[x] UX tested
[x] Browsers / platforms tested
[x] Rebased & ready to merge without conflicts
[x] Reviewed own code

github-actions[bot] commented 5 months ago

Visit the preview URL for this PR (updated for commit 6d3c449):

https://ottwebapp--pr499-owa-74-only-remove-t-o7m3qo9c.web.app

_{(expires Sat, 18 May 2024 19:18:02 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: c198f8a3a199ba8747819f7f1e45cf602b777529}

ChristiaanScheermeijer commented 5 months ago

Don't forget to squash and give the commit(s) a nice name for the changelogs 😄 I think the changelog parser skips the OWA-<num>: message commits currently in the develop branch.