Refactor / form fields and control elements - Githubissues

jwplayer / ott-web-app

Reference implementation for JWP-powered apps

Apache License 2.0

70 stars 52 forks source link

Refactor / form fields and control elements #513

Closed MelissaDTH closed 5 months ago

MelissaDTH commented 5 months ago

Description

This PR introduces new Input, Select, FormField and Checkbox components:
- It unifies form field labels, aria attributes and helper text in the FormField component
- It also removes the “(Optional)“ marking from custom components for fields that are not required
- Adds an asterisks * to a field if it is required and ensures aria-hidden="true" is applied

This PR is based on this previously approved PR #105

Steps completed:

According to our definition of done, I have completed the following steps:

[x] Acceptance criteria met
[x] Unit tests added
[ ] Docs updated (including config and env variables)
[ ] Translations added
[x] UX tested
[x] Browsers / platforms tested
[x] Rebased & ready to merge without conflicts
[x] Reviewed own code