jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
69 stars 52 forks source link

Fix / favicon paths #514

Closed langemike closed 2 months ago

langemike commented 2 months ago

While working on @vitejs/plugin-legacy I noticed some incorrect definitions in index.html.

I guess we didn't notice this because the (fallback) favicon.ico gets rendered in the browser.

I also wrote an e2e test, to verify if all favicons with correct paths get rendered in the browser to prevent an issue like this from happening in the future.