Closed ChristiaanScheermeijer closed 3 weeks ago
Visit the preview URL for this PR (updated for commit 2497afc):
https://ottwebapp--pr530-fix-live-channels-cu-1gyt01rl.web.app
(expires Mon, 17 Jun 2024 13:20:05 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: c198f8a3a199ba8747819f7f1e45cf602b777529
@ChristiaanScheermeijer VCH.ScheduledStart
can be also set to Live Channels (BCL SaaS).
@ChristiaanScheermeijer
VCH.ScheduledStart
can be also set to Live Channels (BCL SaaS).
That's correct; that's the reason why the live channel start date was shown on the cards. We should assume that when the contentType is set to liveChannel
, the live stream is 24x7 and always live. When using contentType liveEvent
, we calculate the live status and date using the BCL params.
That's correct; that's the reason why the live channel start date was shown on the cards. We should assume that when the contentType is set to
liveChannel
, the live stream is 24x7 and always live. When using contentTypeliveEvent
, we calculate the live status and date using the BCL params.
@ChristiaanScheermeijer Live Channels get same custom params as Live Events (except "VCH.ScheduledEnd"). So it is also possible that it is created ("PRE_LIVE") but not live yet.
Thanks for the feedback @AntonLantukh, but that sounds like a new feature to me 😄
We can start with this solution, but I would propose the following as next steps:
Description
This PR introduces two changes and a fix:
Use
contentType
matching for live events custom screen instead of custom paramsAdd support for live channels without TV Guide page
When creating a 24x7 live channel via JWP dashboard the liveChannel contentType is added. This contentType was originally used only for live streams with a TV Guide (EPG). Now, this is only the case when the
liveChannelsId
param is present on the media item.Remove live event start date for 24x7 live channels
The card shows the live event start date for 24x7 live channels because live channels contain the same parameters. Now the card will only show the event start date for live events.
Steps completed:
According to our definition of done, I have completed the following steps: