jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
69 stars 53 forks source link

Fix / live channels custom screen #530

Closed ChristiaanScheermeijer closed 3 weeks ago

ChristiaanScheermeijer commented 1 month ago

Description

This PR introduces two changes and a fix:

Use contentType matching for live events custom screen instead of custom params

Add support for live channels without TV Guide page

When creating a 24x7 live channel via JWP dashboard the liveChannel contentType is added. This contentType was originally used only for live streams with a TV Guide (EPG). Now, this is only the case when the liveChannelsId param is present on the media item.

Remove live event start date for 24x7 live channels

The card shows the live event start date for 24x7 live channels because live channels contain the same parameters. Now the card will only show the event start date for live events.

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 1 month ago

Visit the preview URL for this PR (updated for commit 2497afc):

https://ottwebapp--pr530-fix-live-channels-cu-1gyt01rl.web.app

(expires Mon, 17 Jun 2024 13:20:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

AntonLantukh commented 1 month ago

@ChristiaanScheermeijer VCH.ScheduledStart can be also set to Live Channels (BCL SaaS).

ChristiaanScheermeijer commented 1 month ago

@ChristiaanScheermeijer VCH.ScheduledStart can be also set to Live Channels (BCL SaaS).

That's correct; that's the reason why the live channel start date was shown on the cards. We should assume that when the contentType is set to liveChannel, the live stream is 24x7 and always live. When using contentType liveEvent, we calculate the live status and date using the BCL params.

AntonLantukh commented 1 month ago

That's correct; that's the reason why the live channel start date was shown on the cards. We should assume that when the contentType is set to liveChannel, the live stream is 24x7 and always live. When using contentType liveEvent, we calculate the live status and date using the BCL params.

@ChristiaanScheermeijer Live Channels get same custom params as Live Events (except "VCH.ScheduledEnd"). So it is also possible that it is created ("PRE_LIVE") but not live yet.

ChristiaanScheermeijer commented 1 month ago

Thanks for the feedback @AntonLantukh, but that sounds like a new feature to me 😄

AntonLantukh commented 4 weeks ago

We can start with this solution, but I would propose the following as next steps:

  1. Have one screen, which is "Live" (MediaEvent now) for all live events except ones being part of EPG
  2. In case we have start time / end time -> we show it. If not -> it will look like a MediaMovie.
  3. Tags will be just rendered conditionally depending on the presence