jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Fix / waiting for payment PPV/TVOD offers #541

Closed ChristiaanScheermeijer closed 3 months ago

ChristiaanScheermeijer commented 4 months ago

Description

This PR fixes issue #518. I've updated the formatted offerId in the JWP integration. The offerId is now composed of the offer prefix, asset ID, and access fee ID. The composed offer ID is added to the URL when the user is sent to the waiting for payments modal. The integration is responsible for retrieving the asset ID when needed.

I also encountered a problem because the getSubscriptionSwitches method threw an error in the initialiseOffers method. This caused the query to retry a few times before resolving, making the Choose offers modal really slow.

The third change is that the welcome modal isn't shown to users buying PPV access since the welcome modal shows a message stating "You now have access to all content", which isn't true when buying access to a single item.

github-actions[bot] commented 4 months ago

Visit the preview URL for this PR (updated for commit 4cfbde8):

https://ottwebapp--pr541-fix-waiting-for-paym-3vrp1mm6.web.app

(expires Sat, 06 Jul 2024 10:03:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529