jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Remove Profiles feature from WebApp #543

Closed borkopetrovicc closed 3 months ago

borkopetrovicc commented 3 months ago

Description

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit 834b68a):

https://ottwebapp--pr543-fix-remove-profiles-c33gby1w.web.app

(expires Thu, 11 Jul 2024 12:37:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

AntonLantukh commented 3 months ago

@borkopetrovicc I still see some profile parts:

Screenshot 2024-06-06 at 22 12 29 Screenshot 2024-06-06 at 22 12 39
borkopetrovicc commented 3 months ago

@borkopetrovicc I still see some profile parts:

Screenshot 2024-06-06 at 22 12 29 Screenshot 2024-06-06 at 22 12 39

ce7e78b2bf4060b591255416736cb4fd8b4bc2b3

AntonLantukh commented 3 months ago

Please also remove Profile paths:

        <Route path={PATH_USER_PROFILES} element={<Profiles />} />
        <Route path={PATH_USER_PROFILES_CREATE} element={<CreateProfile />} />
        <Route path={PATH_USER_PROFILES_EDIT} element={<Profiles editMode />} />
        <Route path={PATH_USER_PROFILES_EDIT_PROFILE} element={<EditProfile />} />
ChristiaanScheermeijer commented 3 months ago

This commit won't show in the changelog :')