jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
69 stars 53 forks source link

Fix/ Remove features from web app #555

Closed borkopetrovicc closed 1 week ago

borkopetrovicc commented 3 weeks ago

Description

https://jwplayer.atlassian.net/jira/software/c/projects/PS/boards/575?selectedIssue=PS-242

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 3 weeks ago

Visit the preview URL for this PR (updated for commit 6775e87):

https://ottwebapp--pr555-fix-remove-features-g0gps13u.web.app

(expires Sat, 27 Jul 2024 13:32:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

AntonLantukh commented 2 weeks ago

@borkopetrovicc it looks like tests are failing because of the code that was removed. Can you look into it?

AntonLantukh commented 1 week ago

@borkopetrovicc it looks looks good to me in general but I didn't work a lot with the payments logic. @ChristiaanScheermeijer any concerns you have here?

ChristiaanScheermeijer commented 1 week ago

I'm afraid this also removal doesn't take the Cleeng integration into consideration. We want to keep that logic intact as much as possible.

Also, when using Cleeng, I now see two cancel subscription buttons:

image

borkopetrovicc commented 1 week ago

I'm afraid this also removal doesn't take the Cleeng integration into consideration. We want to keep that logic intact as much as possible.

Also, when using Cleeng, I now see two cancel subscription buttons:

image

8da8eadb1203eebfccc7b980f0abd52455b2706d

ChristiaanScheermeijer commented 1 week ago

@dbudzins perhaps we could add some more description/definition to the PR descriptions like we do? That helps us to better understand the desired outcome and review this more efficient.