jwplayer / ott-web-app

Reference implementation for JWP-powered apps
Apache License 2.0
70 stars 52 forks source link

Fix/ Remove features from web app #562

Closed borkopetrovicc closed 3 months ago

borkopetrovicc commented 3 months ago

Description

https://jwplayer.atlassian.net/jira/software/c/projects/PS/boards/575?selectedIssue=OWA-78

This PR solves # .

Steps completed:

According to our definition of done, I have completed the following steps:

github-actions[bot] commented 3 months ago

Visit the preview URL for this PR (updated for commit f3ef051):

https://ottwebapp--pr562-fix-remove-features-stcju3ku.web.app

(expires Sat, 27 Jul 2024 14:10:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

ChristiaanScheermeijer commented 3 months ago

If you're trying to disable those features, instead of inverting the condition (essentially enabling them for Cleeng), you can update the feature flags here:

https://github.com/jwplayer/ott-web-app/blob/64b6fedf771bc5fb31faccd7c0087e93ffed7a45/packages/common/src/services/integrations/jwp/JWPAccountService.ts#L60-L73