search

jwr1 / interstellar

An app for Mbin and Lemmy, connecting you to the fediverse.
https://kbin.earth/m/interstellar
GNU General Public License v3.0
27 stars 4 forks source link

Adds highlighting for user mentions. #18

Closed olorin99 closed 4 months ago

olorin99 commented 4 months ago

Replaces @mentions in markdown with a inkwell that routes to the users profile when clicked.

olorin99 commented 4 months ago

Lol didn't pull before pushing this.

jwr1 commented 4 months ago

The functionality of user/magazine mentions should be done, but I'm still working on the visual indicator. At the moment, this is how it looks:

image

jwr1 commented 4 months ago

It should be done now, if you want to try it out or make suggestions.

olorin99 commented 4 months ago

Looks great. One thing I noted is that apparently magazine mentions can also be @ magazine. The main use case seems to be mastodon users posting in lemmy communities

However it seems to conflict with user mentions like at https://kbin.social/m/kbinMeta/t/828882/So-what-s-going-on where the @ tech links to a user instead of the magazine. So it is probably better not to handle that case.

jwr1 commented 4 months ago

I hadn't thought of that. Microblogging is half of kbin, but I don't think the use cases outway the weird problems it could cause. We can easily add it later on though, if we think it'd be useful.

olorin99 commented 4 months ago

Agreed. In the few cases I could find the link to the magazine is right there anyway next to the username so there's little to no impact on usability.