search

jwrdegoede / rtl8189ES_linux

79 stars 92 forks source link

Fix wireless regulatory API misuse #55

Closed CGarces closed 3 years ago

CGarces commented 3 years ago

Port of https://github.com/torvalds/linux/commit/81f153faacd04c049e5482d6ff33daddc30ed44e ping @martinayotte for testing.

Fix #51

martinayotte commented 3 years ago

Thanks, @CGarces , for this patch ! I've included it in my Armbian 5.11.1 builds successfully ! Will merge it in Armbian github until Hans merge it into his branches.

martinayotte commented 3 years ago

Oh ! I will revert/delete Armbian patch if it is both merged in rtl8189es and rtl8189fs branches ...

jwrdegoede commented 3 years ago

Thanks, @CGarces , for this patch ! I've included it in my Armbian 5.11.1 builds successfully ! Will merge it in Armbian github until Hans merge it into his branches.

@martinayotte I no longer actively use any boards with the rtl8189fs / rtl8189es wifi chips myself. So I've handed over maintenance over to the community by giving interested people commit access to this git repo. Which as you can see seems to work well :)

Note since people are still using this git-repo after all these years since I started this I wonder if it would not be a good idea to push this driver to drivers/staging in the mainline kernel, like I did with the rtl8723bs driver (which I do still use myself)... ?

If there is someone interested in taking the task of getting this driver added to drivers/staging, I would be happy to help mentor / coach them for this and do an initial review of the patch before submitting it to Greg.

One of the first steps would be to figure out what to do with the rtl8189es/rtl8189fs difference. I don't know how big the difference between the branches is. If it is not that big, then ideally the 2 branches should be merged into 1 branch using different paths for the 2 variants which are selected at runtime based on the model being used. If the differences are too big for that, then we should add this to drivers/staging as 2 separate drivers (in 2 separate patches).

Note getting this added to drivers/staging will likely require a significant amount of time initially; and then a bit of time every week / 2 weeks for helping with reviewing patches after it has been merged.

martinayotte commented 3 years ago

@jwrdegoede , thanks for the explanation. If @CGarces is volonteer to do the mainlining, I will then follow the ML and take care that Armbian will follow ...

Cacodemon345 commented 3 years ago

This fix is needed in the master branch; I am one of those people affected by the #51 issue and my device/board has a RTL8189ES SDIO chip.

CGarces commented 3 years ago

Hi all.

Thanks @jwrdegoede for your offer but I think that I don't have enough knowledge to deal with mainline kernel. I'm not a C developer. I have ported this PR to the main branch at #57