search

jwrdegoede / rtl8189ES_linux

79 stars 92 forks source link

Add kernel 5.17+ patch for RTL8189FS #67

Closed adeepn closed 2 years ago

adeepn commented 2 years ago

Cherry-pick from https://github.com/jwrdegoede/rtl8189ES_linux/pull/66

CGarces commented 2 years ago

Thanks! Looks fine for me but can you please rebase after #69 and #70 ?

adeepn commented 2 years ago

Rebased.

CGarces commented 2 years ago

Ouch! Please check the logs from the build, change that "comp" variable to NULL

adeepn commented 2 years ago

hmm.. I built these drivers in armbian and everything was fine. i'l research this tomorrow

adeepn commented 2 years ago

Oops.

adeepn commented 2 years ago

Fixed.

CGarces commented 2 years ago

Thanks. Fell free to apply https://github.com/Mange/rtl8192eu-linux-driver/pull/265/files To fix some new warning errors.

sergey-suloev commented 2 years ago

Thanks. Fell free to apply https://github.com/Mange/rtl8192eu-linux-driver/pull/265/files To fix some new warning errors.

hey, is this applied ?

sergey-suloev commented 2 years ago

@CGarces is the following issue related ?

[ 8.316718] rtl8189es mmc1:0001:1 wlan0: Current addr: 54 c9 df 38 d0 e3 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 8.330366] rtl8189es mmc1:0001:1 wlan0: Expected addr: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 [ 8.343963] ------------[ cut here ]------------ [ 8.348598] netdevice: wlan0: Incorrect netdev->dev_addr [ 8.353997] WARNING: CPU: 3 PID: 207 at net/core/dev_addr_lists.c:517 dev_addr_check+0x98/0x140 [ 8.362721] Modules linked in: sunxi_wdt virt_dma sun4i_drm sun4i_frontend drm_cma_helper crct10dif_ce sun4i_tcon display_connector sun8i_tcon_top drm_kms_helper cfbfillrect cfbimgblt cfbcopyarea 8189es(O) cfg80211 rfkill drm drm_panel_orientation_quirks ip_tables x_tables [ 8.386931] CPU: 3 PID: 207 Comm: systemd-network Tainted: G O 5.18.0-rc3-sunxi #stable [ 8.396242] Hardware name: FriendlyARM NanoPi A64 (DT) [ 8.401378] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 8.408340] pc : dev_addr_check+0x98/0x140 [ 8.412440] lr : dev_addr_check+0x98/0x140 [ 8.416536] sp : ffff8000090eb620 [ 8.419848] x29: ffff8000090eb620 x28: ffff0000021fa940 x27: ffff8000090eb8c0 [ 8.426988] x26: ffff000001d28000 x25: 0000000000000001 x24: 0000000000000000 [ 8.434125] x23: ffff000001d28238 x22: 0000000000001002 x21: ffff8000009e9ce8 [ 8.441264] x20: ffff000001d28000 x19: ffff000001d28000 x18: 0000000000000030 [ 8.448402] x17: 0000000000000000 x16: 0000000000000000 x15: 0761075f07760765 [ 8.455540] x14: 000000000000030d x13: 0000000000000001 x12: 0000000000000001 [ 8.462677] x11: 0000000000000000 x10: 0000000000000960 x9 : ffff8000090eb3d0 [ 8.469814] x8 : ffff0000021fb300 x7 : ffff00003fda5a40 x6 : 0000000000000000 [ 8.476950] x5 : 0000000000000000 x4 : ffff00003fd9f898 x3 : ffff00003fda28e0 [ 8.484088] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0000021fa940 [ 8.491225] Call trace: [ 8.493671] dev_addr_check+0x98/0x140 [ 8.497420] dev_open+0x40/0x1bc [ 8.500828] __dev_change_flags+0x194/0x210 [ 8.505013] dev_change_flags+0x28/0x6c [ 8.508852] do_setlink+0x224/0xd50 [ 8.512344] rtnl_setlink+0xe4/0x190 [ 8.515922] rtnetlink_rcv_msg+0x118/0x334 [ 8.520020] netlink_rcv_skb+0x5c/0x130 [ 8.523859] rtnetlink_rcv+0x1c/0x2c [ 8.527436] netlink_unicast+0x250/0x310 [ 8.531359] netlink_sendmsg+0x1b0/0x400 [ 8.535283] sys_sendto+0x120/0x160 [ 8.538947] __arm64_sys_sendto+0x2c/0x40 [ 8.542957] invoke_syscall+0x48/0x114 [ 8.546711] el0_svc_common.constprop.0+0xcc/0xec [ 8.551415] do_el0_svc+0x28/0x90 [ 8.554732] el0_svc+0x2c/0x84 [ 8.557790] el0t_64_sync_handler+0xec/0xf0 [ 8.561974] el0t_64_sync+0x18c/0x190 [ 8.565637] ---[ end trace 0000000000000000 ]---

CGarces commented 1 year ago

Please check PR #99 and #100 Maybe are related.