search

jwsmith24 / palette

An interactive rubric builder and grading assistant to improve the group project grading experience on Canvas.
1 stars 0 forks source link

refactor: backend conversions #96

Closed jwsmith24 closed 1 week ago

jwsmith24 commented 1 week ago

Most important fix: updated the rubric id parsing in the assignments controller to grab to correct numeric rubric id.

Testing led to the discovery that the backend controllers were passing canvas data directly to the frontend without processing it.

Began incremental refactor of backend controllers to simplify the protocol and transformation process while ensuring proper type guards are still in place.

jwsmith24 commented 1 week ago

New tests for the GET rubric controllers are operational AND passing 🚀

Consolidated both into a getRubricsTest file to avoid creating the same mocks twice

jwsmith24 commented 1 week ago

Also removed all the key-related tests and elements since the backend shouldn't ever be assigning keys (they only exist within the react app)

I updated the types to make the key field optional to be in line with how we're handling id. We can add a check for it on the frontend if we want to be extra safe!