Query parameters for GET

jwstegemann / fritz2

Easily build reactive web-apps in Kotlin based on flows and coroutines.

https://www.fritz2.dev

MIT License

636 stars 25 forks source link

Query parameters for GET #790

Closed serras closed 10 months ago

serras commented 11 months ago

queryParameters function which encodes a map of strings into the right form,
additional optional argument to get, since query parameters often appear in such requests.

Lysander commented 10 months ago

We already had some feature request for url-query-parameters: https://github.com/jwstegemann/fritz2/issues/757

I have some doubts, whether this will really pay off, as there are so many cornercases with those parameters. Do you think we can document that in such a way, that the use cases and the limitations become clear enough?

serras commented 10 months ago

I think this should really be exposed, at least for GET, because the workaround of adding it by hand is quite messy.

What I think makes this solution nice is that I piggy back on JavaScript's native URL encoding functions, so there should be fewer problems there.