jwstegemann / fritz2

Easily build reactive web-apps in Kotlin based on flows and coroutines.
https://www.fritz2.dev
MIT License
653 stars 28 forks source link

Fixes recent build issues #881

Closed haukesomm closed 1 month ago

haukesomm commented 1 month ago

This PR fixes two build issues that recently occurred in our project.

Deprecation of the GitHub Actions upload-artifact task v1 and v2

The above mentioned task has been deprecated and its use now causes pipelines to fail. As a fix, this PR updates the version to consistently be v4, as recommended in the deprecation notice.

Behavior change in Chrome headless

Fixes the failing testBasicAuth test in the http.kt test file.

The failing test was caused by a change of behavior in Chrome headless, displaying an authentication popup when a 401 status was received from a basic auth endpoint.

The popup cannot be dismissed by our test and causes the respective test to fail, even though all assertions are correct.

As a result, the easies fix is to remove the problematic test case.