Obvious Fix: RSA flaky test

jwtk / njwt

Node.js JWT support

Apache License 2.0

432 stars 49 forks source link

Obvious Fix: RSA flaky test #74

Open alesbolka opened 4 years ago

alesbolka commented 4 years ago

Signing algorithm was not set correctly
Result of token validation was not checked

Test failed even though the validation was not done properly

swiftone commented 4 years ago

@alesbolka - Thanks for the PR!

Okta now maintains this repo, so the contribution rules have updated a bit.

While your changes are fairly small, it would make things easier if you either: 1) Signed a CLA and emailed it as described here: https://developer.okta.com/cla/ OR 2) Change the PR title to include "Obvious Fix", showing your agreement to that interpretation

Then we'll forward with this.

Thanks again for the PR, and thanks for dealing with this one-time legal hassle.