jwueller / jellyfin-plugin-onepace

Jellyfin metadata and cover art integration for the https://onepace.net/ project
https://onepace.net/
GNU General Public License v3.0
59 stars 3 forks source link

Plugin not creating season for 'Whiskey Peak' and 'Post-Enies Lobby' #34

Closed maeveuay closed 6 months ago

maeveuay commented 10 months ago

Hello!

This plugin is working a treat other than two Arcs not being given their own Jellyfin 'Season' Is there something wrong with my naming/folder scheme? I got it from a One Pace Batch download, and they named it for Plex, so I renamed everything to the format you see in the images below.

Jellyfin: image File Structure: image image

If you need any logs just lemme know :)

NunoMouraz commented 9 months ago

@maeveuay I believe the problem is due to the fact of how the plugin's arc search was made:

In the case of your path D:\...\One Pace - Arc 18 - Post-Enies Lobby:

@maeveuay How to fix it yourself? Well, for example, just add 431-441 aka (the manga chapters) somewhere in there, since it searches for that stuff first. Something like: One Pace - Arc 20 - Post-Enies Lobby [431-441]. Then rescan your library / metadata. Maybe it will also work on the other chapter.

How should the plugin fix it? IDK. Maybe try to the find the longest match or something 😊: ArcIdentifier.cs solution

maeveuay commented 9 months ago

Thank you! The trick worked for Post-Enies, but not for Reverse Whiskey Arc. Bit new to Github, should I close the issue?

jwueller commented 6 months ago

Hi, sorry for not getting to this sooner.

First of all, thank you @NunoMouraz for taking this on! As they correctly identified, this is an issue with the matching logic in the plugin, which has now been fixed in version 1.4.0.0.

However, there is also a different issue in this case: The Arc is called "Whisky Peak", not "Whiskey Peak". This is such a common misspelling, that even the One Pace team has made this mistake in the past, particularly in release filenames. The new version also deals with this by accepting both spellings.

Hopefully that resolves all of your issues. Thanks for reporting them! Please feel free to reopen this if you are still observing weirdness with the matching.