search

jwunderl / arcade-tilemap-a-star

a star implementation for tilemaps in pxt-arcade ---beta
https://jwunderl.github.io/arcade-tilemap-a-star/
MIT License
6 stars 6 forks source link

General purpose heap #2

Open pelikhan opened 4 years ago

pelikhan commented 4 years ago

Since this is not specific to arcade, we should make sure this data structure works in microbit too. Maybe rename to

pxt-heap

jwunderl commented 4 years ago

I put the heap into https://github.com/jwunderl/pxt-heap already actually, which in theory should work across the board (probably have to add to readme.md for search to pick it put though?). This repo's specific to arcade at the moment as it's based around tilemap.

pelikhan commented 4 years ago

You can move arcade specific dependencies to "testDependencies"

jwunderl commented 4 years ago

Hm, it's definitely non trivial to make a package usable by multiple targets at the moment; "testDependencies" only works if the main package compiles without the "testDependencies", so you also have to include at least the package that contains the builtin types ("core"); I'm assuming this is fine across the board as everything probably has a core dep, but it makes it awkward and reimporting the extension didn't work till after you manually delete the old copy. Anyway, as far as I can tell it works in beta microbit now (won't work in live as there are a few language features like array unpacking that haven't made it there yet).

Ideally we could probably just have a checkbox or something for most of the targets, and use that to build pxt json - e.g. we know if we're going to work on both arcade and microbit we need to add it to the list of supportedEditors, downgrade device to core (probably?) in deps, and add any target specific repos to testDeps

pelikhan commented 4 years ago

Tested in one but works in all...

From: Joey Wunderlich notifications@github.com Sent: Sunday, April 26, 2020 5:25:04 PM To: jwunderl/arcade-tilemap-a-star arcade-tilemap-a-star@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Author author@noreply.github.com Subject: Re: [jwunderl/arcade-tilemap-a-star] General purpose (#2)

Hm, it's definitely non trivial to make a package usable by multiple targets at the moment; "testDependencies" only works if the main package compiles without the "testDependencies", so you also have to include at least the package that contains the builtin types ("core"); I'm assuming this is fine across the board as everything probably has a core dep, but it makes it awkward and reimporting the extension didn't work till after . Anyway, as far as I can tell it works in beta microbit now (won't work in live as there are a few language features like array unpacking that haven't made it there yet).

Ideally we could probably just have a checkbox or something for most of the targets, and use that to build pxt json - e.g. we know if we're going to work on both arcade and microbit we need to add it to the list of supportedEditors, downgrade device to core (probably?) in deps, and add any target specific repos to testDeps

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjwunderl%2Farcade-tilemap-a-star%2Fissues%2F2%23issuecomment-619649085&data=02%7C01%7Cjhalleux%40microsoft.com%7Cda74645e443e4d6b31a408d7ea416ebd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637235439076055308&sdata=NWC4o5%2BYWK4hbzmSbydmgiFOugUXj68kfInjOyfwGaQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKOVFVNQQCBOWA7ZZH3ROTGGBANCNFSM4MRCBSWQ&data=02%7C01%7Cjhalleux%40microsoft.com%7Cda74645e443e4d6b31a408d7ea416ebd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637235439076055308&sdata=iUaoJMVo7N7w9EUKQdnH7ILLVv3WnzLSA0mEeeKDy%2Fg%3D&reserved=0.