search

jwvdiermen / grunt-include-source

Include lists of files into your source files automatically.
MIT License
68 stars 31 forks source link

provides support for options.rename function #28

Closed isadovskiy closed 9 years ago

isadovskiy commented 9 years ago

This commit replaces grunt.file.expand call with grunt.file.expandMapping. It allows to use extended set of the file configuration options (see http://gruntjs.com/api/grunt.file#grunt.file.expandmapping).

This commit also adds support for options.rename configuration parameter, which allows to create more advanced configurations.

jwvdiermen commented 9 years ago

Thanks for the PR. Could you add some documentation about the extra option in the README, and write some unit tests where this option is utilized?

isadovskiy commented 9 years ago

Will do.

isadovskiy commented 9 years ago

BTW, do you prefer single commit? Or multiple commits within pull request are fine?

jwvdiermen commented 9 years ago

I guess splitting commits so every message only describes one subject will do it. So, it depends.

In this case, 1 commit for the tests and another for documentation. Multiple commits are preferred in that case.

gabe-villarreal commented 9 years ago

I know this PR is almost 6 months old but hoping it can be revived and merged into the master for release. A project I'm working on could benefit from the expandMapping 'rename' option. If any help is needed, let me know. Looks like all that is missing is the unit test and documentation update.

isadovskiy commented 9 years ago

@gabe-villarreal, feel free to fork my branch and complete tests/docs. Or I can give you permissions to do the changes in my branch.

I just did not have time to complete this initially and then forget about..

gabe-villarreal commented 9 years ago

no worries. yeah, I'll go ahead and fork it.

isadovskiy commented 9 years ago

closing this pull request and creating the new one, with updated docs and tests.