jwwong / proxy-vole

Automatically exported from code.google.com/p/proxy-vole
0 stars 0 forks source link

HTTPS missing from JavaProxySearchStrategy #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It doesn't look like the class JavaProxySearchStrategy is picking up the https 
system settings. There should be some code like this added:

String hostHttps = System.getProperty("https.proxyHost");
String portHttps = System.getProperty("https.proxyPort", "80");

<snip>

if (whiteList.trim().length() > 0) {
    ps.setSelector("http", new ProxyBypassListSelector(whiteList,  FixedProxySelector(host, Integer.parseInt(port))));
    ps.setSelector("https", new ProxyBypassListSelector(whiteList, new FixedProxySelector(hostHttps, Integer.parseInt(portHttps))));
} else {
    ps.setSelector("http", new FixedProxySelector(host, Integer.parseInt(port)));
    ps.setSelector("https", new FixedProxySelector(hostHttps, Integer.parseInt(portHttps)));
}

Original issue reported on code.google.com by awbra...@gmail.com on 1 Nov 2011 at 6:21

GoogleCodeExporter commented 9 years ago
Hi,
I could add this. But is this really very common? I googled a bit and on the 
offical Java Docu 
http://download.oracle.com/javase/1.5.0/docs/guide/net/properties.html
they only mention http.proxyHost but it seems that some other places also 
mention https.proxyHost

Does the default Oracle Proxy Selector support this? I need to so some testing 
on this and if yes I will also include this.

Thanks for the hint regarding this.
Have fun,
-Rossi

Original comment by rosstaus...@googlemail.com on 1 Nov 2011 at 8:15

GoogleCodeExporter commented 9 years ago

Original comment by rosstaus...@googlemail.com on 1 Nov 2011 at 8:15

GoogleCodeExporter commented 9 years ago
Its not a big deal for me. I was just reading over the code and comparing to 
this document and noticed the discrepancy.

http://download.oracle.com/javase/6/docs/technotes/guides/net/proxies.html

Original comment by awbra...@gmail.com on 1 Nov 2011 at 8:54

GoogleCodeExporter commented 9 years ago

Original comment by rosstaus...@googlemail.com on 1 Nov 2011 at 8:56