search

jwyatt1999 / CITS3403_Cartographers

CITS3403 Project - Josh Wyatt & Joo Kai Tay
0 stars 1 forks source link

Add Full Implementation of Score Cards #19

Closed jwyatt1999 closed 2 years ago

jwyatt1999 commented 2 years ago

In this PR I have added the full implementation of score cards. Previously we gave a base 2 points for each village / forest space and 1 point for each farm / river space. Now we have the legit score cards from the board game and I've also added the placement score cards which are always scored at the end of the third season.

The score card selection is now randomized AND it's pretty easy to add more score cards in the future / remove score cards from the pool if we wish to do so.

A lot of the score cards involve pretty involved algorithms - particularly the village score cards - so definitely let me know if you think any of the methods need more comments to make it clear exactly how the algorithms work.

jwyatt1999 commented 2 years ago

Hey @Bsubs , this is ready for review. I suggest reviewing https://github.com/jwyatt1999/CITS3403_Cartographers/pull/17 first since this branch builds on changes made in that PR. Once that PR is merged I'll pull in main and it'll be easier to review these changes.

jwyatt1999 commented 2 years ago

I've pulled in main, this is now ready for review @Bsubs

jwyatt1999 commented 2 years ago

I would hold off on reviewing this just yet - I'll need to make some changes after you've merged in your branch to main.

jwyatt1999 commented 2 years ago

@Bsubs , this is now ready for review. I've tested the changes and they work as they did before the file shuffle.

After this is merged, I'll pull the changes into https://github.com/jwyatt1999/CITS3403_Cartographers/pull/20 then fix anything to get it ready for review.

Bsubs commented 2 years ago

Looks good, I'll merge it into main now.