Closed jwyatt1999 closed 2 years ago
Hey @Bsubs , this will probably be the last PR (from me) which is actually delivering content. I've run all the validation, tests, etc. etc. and it all passed so this is ready for review :)
Looks good, splitting the css into 2 files is a freat idea for maintainability
For this PR I went through all of our HTML and CSS files and fixed any inconsistencies or issues I found. I 99% of the style from the html files into the css files and then organised the css files by page / logical group.
I have run the css files and generated html pages through the validator and they all passed.
I also added a few extra system test cases for the new leaderboard feature of showing the average scores.
I have also updated requirements.txt to match the current application requirements (I don't anticipate we will need to make any further changes to this unless we are adding new functionality).
HTML pages were validated by running application then pressing
Ctrl + U
on the page and copying the HTML into the w3 validator. CSS page was validated by throwing in the source code.HTML pages validated:
CSS pages validated:
Automated testing: