search

jxcore / jxm

Incredibly fast messaging backend for Node.JS / JXcore
http://jxm.io
Other
226 stars 30 forks source link

Fixes iOS detection #26

Closed brunobg closed 9 years ago

brunobg commented 9 years ago

The previous code returned true in Android devices.

plika commented 9 years ago

LGTM but wondering why Apple is not sufficient.

brunobg commented 9 years ago

"Apple" appears in the user agent of Chrome Android.

obastemur commented 9 years ago

@brunobg ping! this PR needs an update

brunobg commented 9 years ago

What exactly is needed from me? I don't have write access to your repo. It also seems that the conflict came from accepting https://github.com/jxcore/jxm/pull/27 first, no?

obastemur commented 9 years ago

You are invited as a contributor, please check your email. Thanks

brunobg commented 9 years ago

Sorry, I couldn't solve the conflict, so I commited the fix. https://github.com/jxcore/jxm/commit/99d1b66919b5f1843d163c2fe8d2b9cb394aa06d

Closing this.

obastemur commented 9 years ago

Okay thanks