jxjo / PlanformCreator2

An app for creating the planform of a wing
MIT License
34 stars 7 forks source link

Error: colorama import just_fix_windows_console under Ubuntu 20.04 #8

Closed klausbu closed 6 months ago

klausbu commented 6 months ago

Hello,

would you please update the code so it can be used under Linux, in my case Ubuntu 20.04. The problem is, Windows specific code causing the following error because it's not recognizing Linux:

%%% python3 PlanformCreator2.py Traceback (most recent call last): File "/home/klaus/Programme/PlanformCreator2SC/PlanformCreator2.py", line 47, in from common_utils import * File "/home/klaus/Programme/PlanformCreator2SC/modules/common_utils.py", line 9, in from colorama import just_fix_windows_console ImportError: cannot import name 'just_fix_windows_console' from 'colorama' (/usr/lib/python3/dist-packages/colorama/init.py)

The fix is probably wrapping the function according to: https://docs.python.org/3/library/sys.html#sys.platform so it's omitted when running the software under Linux.

Thank you!

jxjo commented 6 months ago

Hello Klaus,

thank you for this issue!

... this is strange since up to now this problem didn't arise...

Anyway - I made a fix and just pushed it. Could you "clone" again and check, if it works?

Thank you!

klausbu commented 6 months ago

Hello,

it works!

Question: Is there a way/trick to define a constant trailing edge thickness e.g. 0.5mm in the sense of "design for manufacturing"

jxjo commented 6 months ago

Hello Klaus,

... supi! (thank you for testing)

--

Yes, you can set the te gap in mm when exporting based on the local chord:

grafik

(te gap can also be set in 'dxf export')

jxjo commented 6 months ago

Bug fixed