jxmorris12 / PokemonGo-Finder

Live visualization of all the pokemon in your area... and more!
GNU General Public License v3.0
171 stars 43 forks source link

Notifications not Working #24

Closed padenshorey closed 8 years ago

padenshorey commented 8 years ago

Notifications are no longer being sent as...

pokemons[poke.SpawnPointId] = pokemon_obj

needs to be moved after the if statement in main.py

I'm just new to GitHub and not sure how to fix it myself.

rickhlx commented 8 years ago

Having same issue

Erid commented 8 years ago

The fix worked for me, you should try to do a pull request. Fork this repository, do the change on your branch, go to https://github.com/jxmorris12/PokemonGo-Finder/pulls and there you can create a pull request using your branch.

paperc07 commented 8 years ago

explain this better, where do I put it I cant get it to work

EDIT: I did this and it's working

  if poke.SpawnPointId not in pokemons:
    pokemons[poke.SpawnPointId] = pokemon_obj
    notifier.pokemon_found(pokemon_obj)
prestia commented 8 years ago

I submitted a pull request to fix this earlier today.

paperc07 commented 8 years ago

oh ok thanks, I got it sorted now

bobsage123 commented 8 years ago

Unfortunately the below trick doesn't work for me. When I do this the command prompt immediately closes itself.

poke.SpawnPointId not in pokemons: pokemons[poke.SpawnPointId] = pokemon_obj notifier.pokemon_found(pokemon_obj)

tivie commented 8 years ago

Python is indentation sensitive

bobsage123 commented 8 years ago

Just made sure all indents matched up and same thing. Does this look okay? http://i.imgur.com/bJf8ETg.png

prestia commented 8 years ago

@bobsage123 no need to move the print line into the if statement, but that shouldn't break anything.

Have you been able to receive push notifications from Pushbullet otherwise? Might be worth sending a test just to make sure everything is configured properly.

paperc07 commented 8 years ago

mine arent working now ,i just click om it and the google map link doesnt work now ,it was just working yesterday

bobsage123 commented 8 years ago

@prestia I moved the print line below the "#change" and that seems to have resolved the issue. Thanks

jxmorris12 commented 8 years ago

fixed