search

jxmorris12 / language_tool_python

a free python grammar checker 📝✅
GNU General Public License v3.0
434 stars 64 forks source link

Download progress bar does not print correct LT version #88

Open ybracke opened 7 months ago

ybracke commented 7 months ago

The download progress bar that is invoked in this line will always say 'Downloading LanguageTool 6.4', regardless of which version the program actually downloads.

What I did: LanguageTool(language_tool_download_version='6.3'

Expected behavior:

  1. Download LanguageTool-6.3 to ~./cache/language_tool_python
  2. Print Downloading LanguageTool 6.3 to stdout in front of the progress bar.

Actual behavior:

  1. Download LanguageTool-6.3 to ~./cache/language_tool_python
  2. Print Downloading LanguageTool 6.4 to stdout in front of the progress bar.

Possible solutions: In get_http, get the version from url and not from the static LTP_DOWNLOAD_VERSION. Or, pass the variable version from download_lt to download_zip to get_http.