jxmorris12 / vec2text

utilities for decoding deep representations (like sentence embeddings) back to text
Other
673 stars 75 forks source link

Importing Bug in PIP version of library #21

Closed Shiniri closed 8 months ago

Shiniri commented 8 months ago

Thank you for publishing your code! I might've found a bug:

In the pip version of this library the __init__.py file in the models directory differs from the one in the git repository. In the pip version the line from .inversion_from_logits_emb import InversionFromLogitsEmbModel is missing, leading to an import error.

Repository:

from .corrector_encoder import CorrectorEncoderModel  # noqa: F401
from .corrector_encoder_from_logits import CorrectorEncoderFromLogitsModel  # noqa: F401
from .inversion import InversionModel  # noqa: F401
from .inversion_bow import InversionModelBagOfWords  # noqa: F401
from .inversion_decoder import InversionModelDecoderOnly  # noqa: F401
from .inversion_from_logits import InversionFromLogitsModel  # noqa: F401
from .inversion_from_logits_emb import InversionFromLogitsEmbModel  # noqa: F401
from .inversion_na import InversionModelNonAutoregressive  # noqa: F401
from .model_utils import (  # noqa: F401
    EMBEDDER_MODEL_NAMES,
    EMBEDDING_TRANSFORM_STRATEGIES,
    FREEZE_STRATEGIES,
    load_embedder_and_tokenizer,
    load_encoder_decoder,
)

Pip:

from .corrector_encoder import CorrectorEncoderModel  # noqa: F401
from .corrector_encoder_from_logits import CorrectorEncoderFromLogitsModel  # noqa: F401
from .inversion import InversionModel  # noqa: F401
from .inversion_bow import InversionModelBagOfWords  # noqa: F401
from .inversion_decoder import InversionModelDecoderOnly  # noqa: F401
from .inversion_from_logits import InversionFromLogitsModel  # noqa: F401
from .inversion_na import InversionModelNonAutoregressive  # noqa: F401
from .model_utils import (  # noqa: F401
    EMBEDDER_MODEL_NAMES,
    EMBEDDING_TRANSFORM_STRATEGIES,
    FREEZE_STRATEGIES,
    load_embedder_and_tokenizer,
    load_encoder_decoder,
)
jxmorris12 commented 8 months ago

@Shiniri I just published a new version to pypi, 0.0.9. does the bug still occur?

Shiniri commented 8 months ago

Please excuse the late reply. On my end it works correctly now, thank you.

Shiniri commented 8 months ago

Resolved