Fix date/time

[jxmot]

The date/time on shown in report.html is behind by 5 hours.

• The dtime array is correct
• The time data is correct

But when time is read from the counter and converted to strings then the time is behind by 5 hours.

Possible Solution:

In mdcount.php -

• Format dtime for time/date separators and use it for reports
  • This has its own problems, all of the older counter files will be formatted incorrectly. This means that there will need to be code to detect the missing date/time separators and put them in as needed.

Elsewhere? -

• Find & fix the problem, not sure where to start looking because all of the code on either end appears correct.

[jxmot]

Chosen Solution:

In mdcount.php -

• Format dtime with time/date separators and use it for reports
  • This has its own problems, all of the older counter files will be formatted incorrectly. This means that there will need to be code to detect the missing date/time separators and put them in as needed. - FIXED: Test for the presence of the separators and only insert them if missing.

The actual issue of the time being off was caused by how the time zone was being set. Although it did not cause any PHP errors or warnings the code was incorrect.

Correct Method:

$tm = $data->time = time();
$dt = new DateTime("@$tm");
$tz = new DateTimeZone(tzone());
$dt->setTimezone($tz);
$data->dtime = array($dt->format('Y-m-d'), $dt->format('H:i:s'));

Wrong Method:

$tm = $data->time = time();
$dt = new DateTime("@$tm", new DateTimeZone(tzone()));
$data->dtime = array($dt->format('Y-m-d'), $dt->format('H:i:s'));

According to the PHP manual setting the time zone in the contstructor is only valid with 'now' in the first argument.